src/runtime/runtime-internal.cc - Issue 2050953003: [wasm] Split off debug info from wasm object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime/runtime-internal.cc

Issue 2050953003: [wasm] Split off debug info from wasm object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@decode-function-offsets-table

Patch Set: address ahaas' comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime/runtime-internal.cc

diff --git a/src/runtime/runtime-internal.cc b/src/runtime/runtime-internal.cc

index 13ba040f1f99dee08fea4b6efb0ffe924f4b4cbe..e7491ba3f485ef98751f3ceb4eeb639112daceb8 100644

--- a/src/runtime/runtime-internal.cc

+++ b/src/runtime/runtime-internal.cc

@@ -619,9 +619,9 @@ RUNTIME_FUNCTION(Runtime_OrdinaryHasInstance) {

RUNTIME_FUNCTION(Runtime_IsWasmObject) {

HandleScope scope(isolate);

DCHECK_EQ(1, args.length());

- CONVERT_ARG_HANDLE_CHECKED(Object, object, 0);

- bool is_wasm_object = object->IsJSObject() &&

- wasm::IsWasmObject(Handle<JSObject>::cast(object));

+ CONVERT_ARG_CHECKED(Object, object, 0);

+ bool is_wasm_object =

+ object->IsJSObject() && wasm::IsWasmObject(JSObject::cast(object));

return *isolate->factory()->ToBoolean(is_wasm_object);

}

« no previous file with comments | « BUILD.gn ('k') | src/v8.gyp » ('j') | no next file with comments »