chrome/browser/android/banners/app_banner_data_fetcher_android.h - Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.h

Issue 2050933002: Upstream: Add additional checks before creating a WebAPK after clicking "Add to Homescreen" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'create_webapk_requirements_enum_class' into create_webapk_requirements2 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/browser/android/banners/app_banner_data_fetcher_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.h

diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.h b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

index da4e9bdbd0d1bf4ef30aac82f6a083a29505509f..88d58f09798722ed50c0f135847c47cb599817bb 100644

--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.h

+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.h

@@ -8,6 +8,7 @@

#include "base/android/jni_android.h"

#include "base/callback_forward.h"

#include "base/macros.h"

+#include "chrome/browser/android/shortcut_info.h"

#include "chrome/browser/banners/app_banner_data_fetcher.h"

namespace banners {

@@ -40,6 +41,8 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

~AppBannerDataFetcherAndroid() override;

std::string GetBannerType() override;

+ bool CheckManifest(const content::Manifest& manifest,

+ OutputDeveloperMessageCode* code) override;

std::string GetAppIdentifier() override;

private:

@@ -50,6 +53,7 @@ class AppBannerDataFetcherAndroid : public AppBannerDataFetcher {

base::android::ScopedJavaGlobalRef<jobject> native_app_data_;

std::string native_app_package_;

+ ShortcutInfo::Type webapp_type_;

int ideal_splash_image_size_in_dp_;

int minimum_splash_image_size_in_dp_;