Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: media/filters/audio_renderer_algorithm.cc

Issue 205093002: Remove muting for extreme playbackRates. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/audio_renderer_algorithm.cc
diff --git a/media/filters/audio_renderer_algorithm.cc b/media/filters/audio_renderer_algorithm.cc
index e73ce65569ca3d7d60909b88a8e16b5e02183bb9..f990df78b802631cb19f85788d943996f3830766 100644
--- a/media/filters/audio_renderer_algorithm.cc
+++ b/media/filters/audio_renderer_algorithm.cc
@@ -46,12 +46,6 @@ namespace media {
// |search_block_index_| = |search_block_center_offset_| -
// |search_block_center_offset_|.
-// Max/min supported playback rates for fast/slow audio. Audio outside of these
-// ranges are muted.
-// Audio at these speeds would sound better under a frequency domain algorithm.
scherkus (not reviewing) 2014/03/19 19:44:27 FYI I don't believe this comment is necessarily tr
-static const float kMinPlaybackRate = 0.5f;
-static const float kMaxPlaybackRate = 4.0f;
-
// Overlap-and-add window size in milliseconds.
static const int kOlaWindowSizeMs = 20;
@@ -200,8 +194,7 @@ int AudioRendererAlgorithm::FillBuffer(AudioBus* dest, int requested_frames) {
void AudioRendererAlgorithm::SetPlaybackRate(float new_rate) {
DCHECK_GE(new_rate, 0);
playback_rate_ = new_rate;
- muted_ =
- playback_rate_ < kMinPlaybackRate || playback_rate_ > kMaxPlaybackRate;
+ muted_ = new_rate == 0.0f;
scherkus (not reviewing) 2014/03/19 19:44:27 dalecurtis: can we rip out all the |muted_| relate
}
void AudioRendererAlgorithm::FlushBuffers() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698