Remove foxit app related setter and getter APIs in XFA code

Remove foxit app related setter and getter APIs in XFA code

No need to get or set foxit app type, name, and version, thus remove
all these APIs and implementation.

Committed: https://pdfium.googlesource.com/pdfium/+/e8a80664a888526ca4f0d08b4e6b290eb0aa0d76

[Wei Li, 2016-06-08 23:53:12]

Description was changed from

==========
Remove foxit app type setter and getter APIs in XFA code

No need for such APIs.
==========

to

==========
Remove foxit app related setter and getter APIs in XFA code

No need to get or set foxit app type, name, and version, thus remove
all these APIs and implementation.
==========

[Wei Li, 2016-06-08 23:53:34]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-06-08 23:54:25]

weili@chromium.org changed reviewers:
+ dsinclair@chromium.org, tsepez@chromium.org

[Wei Li, 2016-06-08 23:54:25]

pls review, thanks

[dsinclair, 2016-06-09 03:39:53]

lgtm

[Tom Sepez, 2016-06-09 18:08:11]

still got red bots.

[Wei Li, 2016-06-09 19:09:56]

On 2016/06/09 18:08:11, Tom Sepez wrote:
> still got red bots.

Yes, thanks to the xfa test file checked in, it turns out that xfa data
structures are more tangled than I thought. I will table this, and
probably revisit later. thanks.

[dsinclair, 2016-06-13 19:22:33]

On 2016/06/09 19:09:56, Wei Li wrote:
> On 2016/06/09 18:08:11, Tom Sepez wrote:
> > still got red bots.
> 
> Yes, thanks to the xfa test file checked in, it turns out that xfa data
> structures are more tangled than I thought. I will table this, and
> probably revisit later. thanks.


out of curiosity, how did this change break the test? Is it doing some kind of
indexing into the arrays or something?

[Wei Li, 2016-06-13 19:41:41]

On 2016/06/13 19:22:33, dsinclair wrote:
> On 2016/06/09 19:09:56, Wei Li wrote:
> > On 2016/06/09 18:08:11, Tom Sepez wrote:
> > > still got red bots.
> > 
> > Yes, thanks to the xfa test file checked in, it turns out that xfa data
> > structures are more tangled than I thought. I will table this, and
> > probably revisit later. thanks.
> 
> 
> out of curiosity, how did this change break the test? Is it doing some kind of
> indexing into the arrays or something?

Yes, you are right, the array data structure I modified is used as a table by
another data
structure so the indexes (along with the content) should be fixed.

[Wei Li, 2016-07-16 02:37:57]

Patchset #3 (id:60001) has been deleted

[Wei Li, 2016-07-16 02:55:31]

Fixed the indexes, ptal, thanks

https://codereview.chromium.org/2050913002/diff/80001/xfa/fxfa/parser/xfa_bas...
File xfa/fxfa/parser/xfa_basic_data_element_script.cpp (right):

https://codereview.chromium.org/2050913002/diff/80001/xfa/fxfa/parser/xfa_bas...
xfa/fxfa/parser/xfa_basic_data_element_script.cpp:63: {47, 0, 523, 2, 316},  
{47, 0, 525, 2, 316},    {47, 0, 527, 2, 316},
It might be a bit hard to review, the changed part is the third field minus 3
from this line and forward since the last entry on prev line has 3 less in the
fourth field.

[dsinclair, 2016-07-18 12:43:39]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-18 12:43:40]

lgtm

[commit-bot: I haz the power, 2016-07-18 12:43:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 13:01:12]

Description was changed from

==========
Remove foxit app related setter and getter APIs in XFA code

No need to get or set foxit app type, name, and version, thus remove
all these APIs and implementation.
==========

to

==========
Remove foxit app related setter and getter APIs in XFA code

No need to get or set foxit app type, name, and version, thus remove
all these APIs and implementation.

Committed:
https://pdfium.googlesource.com/pdfium/+/e8a80664a888526ca4f0d08b4e6b290eb0aa...
==========

[commit-bot: I haz the power, 2016-07-18 13:01:13]

Committed patchset #3 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/e8a80664a888526ca4f0d08b4e6b290eb0aa...