Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.html

Issue 2050903002: MD Settings: About page, fix bug causing update status message to not update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/about_page/about_page.html
diff --git a/chrome/browser/resources/settings/about_page/about_page.html b/chrome/browser/resources/settings/about_page/about_page.html
index fbee7735c6d1f7a6d59b7de9ed5c9c48a67c3dbb..c4a1ccdf4f4e0307189dc4ad29e92f57da61615e 100644
--- a/chrome/browser/resources/settings/about_page/about_page.html
+++ b/chrome/browser/resources/settings/about_page/about_page.html
@@ -79,7 +79,12 @@
hidden="[[!shouldShowUpdateStatusMessage_(
currentUpdateStatusEvent_)]]">
[[getUpdateStatusMessage_(
- currentUpdateStatusEvent_,targetChannel)]]
+<if expr="not chromeos">
+ currentUpdateStatusEvent_)]]
tommycli 2016/06/09 18:40:44 Ah... My only suggestion would be to not split up
dpapad 2016/06/09 18:59:52 Done.
+</if>
+<if expr="chromeos">
+ currentUpdateStatusEvent_,targetChannel_)]]
+</if>
</div>
<span id="deprecationWarning"
hidden="[[!obsoleteSystemInfo_.obsolete]]">
« no previous file with comments | « no previous file | chrome/test/data/webui/settings/about_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698