MD Settings: About page, fix bug causing update status message to not update.

chrome/test/data/webui/settings/about_page_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_about_page', function() {
   /**
    * @constructor
    * @implements {settings.AboutPageBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
@@ skipping 153 matching lines @@
       /** @return {!Promise} */
       function initNewPage() {
         browserProxy.reset();
         PolymerTest.clearBody();
         page = document.createElement('settings-about-page');
         document.body.appendChild(page);
         return browserProxy.whenCalled('refreshUpdateStatus');
       }
 
       /**
-       * Test that the status icon updates according to incoming
-       * 'update-status-changed' events.
+       * Test that the status icon and status message update according to
+       * incoming 'update-status-changed' events.
        */
-      test('IconUpdates', function() {
+      test('IconAndMessageUpdates', function() {
         var icon = page.$$('iron-icon');
         assertTrue(!!icon);
+        var statusMessageEl = page.$.updateStatusMessage;
+        var previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.CHECKING);
         assertEquals(SPINNER_ICON, icon.src);
         assertEquals(null, icon.getAttribute('icon'));
+        assertNotEquals(previousMessageText, statusMessageEl.textContent);
+        previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.UPDATING);
         assertEquals(SPINNER_ICON, icon.src);
         assertEquals(null, icon.getAttribute('icon'));
+        assertNotEquals(previousMessageText, statusMessageEl.textContent);
+        previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.NEARLY_UPDATED);
         assertEquals(null, icon.src);
         assertEquals('settings:check-circle', icon.icon);
-
-        fireStatusChanged(UpdateStatus.NEARLY_UPDATED);
-        assertEquals(null, icon.src);
-        assertEquals('settings:check-circle', icon.icon);
+        assertNotEquals(previousMessageText, statusMessageEl.textContent);
+        previousMessageText = statusMessageEl.textContent;
 
         fireStatusChanged(UpdateStatus.DISABLED_BY_ADMIN);
         assertEquals(null, icon.src);
         assertEquals('cr:domain', icon.icon);
+        assertEquals(0, statusMessageEl.textContent.trim().length);
 
         fireStatusChanged(UpdateStatus.FAILED);
         assertEquals(null, icon.src);
         assertEquals('settings:error', icon.icon);
+        assertEquals(0, statusMessageEl.textContent.trim().length);
 
         fireStatusChanged(UpdateStatus.DISABLED);
         assertEquals(null, icon.src);
         assertEquals(null, icon.getAttribute('icon'));
+        assertEquals(0, statusMessageEl.textContent.trim().length);
       });
 
       /**
        * Test that when the current platform has been marked as deprecated (but
        * not end of the line) a deprecation warning message is displayed,
        * without interfering with the update status message and icon.
        */
       test('ObsoleteSystem', function() {
         loadTimeData.overrideValues({
           aboutObsoleteNowOrSoon: true,
@@ skipping 455 matching lines @@
     registerTests: function() {
       if (cr.isChromeOS) {
         registerDetailedBuildInfoTests();
         registerChannelSwitcherDialogTests();
       }
       registerAboutPageTests();
     },
     registerOfficialBuildTests: registerOfficialBuildTests,
   };
 });