Issue 20509002: Code review changes for r25379

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20509002: Code review changes for r25379 (Closed)

Created:
7 years, 5 months ago by sra1

Modified:
7 years, 5 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Code review changes for r25379 Committed: https://code.google.com/p/dart/source/detail?r=25506

Patch Set 1 : #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -29 lines)			Patch
	M	sdk/lib/_internal/lib/native_helper.dart	View		3 chunks	+23 lines, -28 lines	1 comment	Download
	M	tests/compiler/dart2js_native/fixup_get_tag_test.dart	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #1 manually as r25506 (presubmit successful).

7 years, 5 months ago (2013-07-25 22:09:10 UTC) #1

ahe

7 years, 5 months ago (2013-07-26 10:22:07 UTC) #2

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/20509002/diff/6001/sdk/lib/_internal/lib/nati...
File sdk/lib/_internal/lib/native_helper.dart (right):

https://codereview.chromium.org/20509002/diff/6001/sdk/lib/_internal/lib/nati...
sdk/lib/_internal/lib/native_helper.dart:142: Function getTypeNameOf =
getFunctionForTypeNameOf();
final?

Expand Messages | Collapse Messages