Version 5.1.281.63 (cherry-pick)

src/heap/page-parallel-job.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_PAGE_PARALLEL_JOB_
 #define V8_HEAP_PAGE_PARALLEL_JOB_
 
 #include "src/allocation.h"
 #include "src/cancelable-task.h"
 #include "src/utils.h"
@@ skipping 15 matching lines @@
 //                                     PerPageData page_data)
 //   The function should return true iff processing succeeded.
 // - static const bool NeedSequentialFinalization
 // - static void FinalizePageSequentially(Heap* heap,
 //                                        bool processing_succeeded,
 //                                        MemoryChunk* page,
 //                                        PerPageData page_data)
 template <typename JobTraits>
 class PageParallelJob {
  public:
-  PageParallelJob(Heap* heap, CancelableTaskManager* cancelable_task_manager)
+  // PageParallelJob cannot dynamically create a semaphore because of a bug in
+  // glibc. See http://crbug.com/609249 and
+  // https://sourceware.org/bugzilla/show_bug.cgi?id=12674.
+  // The caller must provide a semaphore with value 0 and ensure that
+  // the lifetime of the semaphore is the same as the lifetime of the Isolate
+  // It is guaranteed that the semaphore value will be 0 after Run() call.
+  PageParallelJob(Heap* heap, CancelableTaskManager* cancelable_task_manager,
+                  base::Semaphore* semaphore)
       : heap_(heap),
         cancelable_task_manager_(cancelable_task_manager),
         items_(nullptr),
         num_items_(0),
         num_tasks_(0),
-        pending_tasks_(new base::Semaphore(0)) {}
+        pending_tasks_(semaphore) {}
 
   ~PageParallelJob() {
     Item* item = items_;
     while (item != nullptr) {
       Item* next = item->next;
       delete item;
       item = next;
     }
-    delete pending_tasks_;
   }
 
   void AddPage(MemoryChunk* chunk, typename JobTraits::PerPageData data) {
     Item* item = new Item(chunk, data, items_);
     items_ = item;
     ++num_items_;
   }
 
   int NumberOfPages() { return num_items_; }
 
@@ skipping 117 matching lines @@
   int num_items_;
   int num_tasks_;
   base::Semaphore* pending_tasks_;
   DISALLOW_COPY_AND_ASSIGN(PageParallelJob);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_PAGE_PARALLEL_JOB_