Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2050853003: [stubs] StringToNumberStub --> StringToNumber builtin. (Closed)

Created:
4 years, 6 months ago by Jarin
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] StringToNumberStub --> StringToNumber builtin. Since some builtins use StringToNumberStub (so the code is always there), it makes more sense to have StringToNumber builtin. Committed: https://crrev.com/546dd77ffcccce42a5751b24bddaa8295efefb4b Cr-Commit-Position: refs/heads/master@{#36843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -174 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/builtins.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +1 line, -22 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +1 line, -19 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +1 line, -22 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Jarin
Could you take a look, please? NonNumberToNumberStub and ToNumberStub will follow soon(ish).
4 years, 6 months ago (2016-06-09 07:26:47 UTC) #2
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-09 07:31:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050853003/1
4 years, 6 months ago (2016-06-09 07:31:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 07:57:04 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:58:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/546dd77ffcccce42a5751b24bddaa8295efefb4b
Cr-Commit-Position: refs/heads/master@{#36843}

Powered by Google App Engine
This is Rietveld 408576698