Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2050823003: Clean-up blink_idl_parser (Closed)

Created:
4 years, 6 months ago by bashi
Modified:
4 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean-up blink_idl_parser - Move p_CallbackOrInterface to the base parser - Remove p_TypeSuffix. This is already handled by the base parser BUG=617899 Committed: https://crrev.com/36889c50c1e61023e78aa27e5876285d0d79cb25 Cr-Commit-Position: refs/heads/master@{#398790}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M third_party/WebKit/Source/bindings/scripts/blink_idl_parser.py View 2 chunks +0 lines, -22 lines 0 comments Download
M tools/idl_parser/idl_parser.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050823003/1
4 years, 6 months ago (2016-06-09 01:48:08 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/173454)
4 years, 6 months ago (2016-06-09 01:57:51 UTC) #4
bashi
PTAL
4 years, 6 months ago (2016-06-09 02:43:48 UTC) #6
haraken
LGTM
4 years, 6 months ago (2016-06-09 04:04:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050823003/1
4 years, 6 months ago (2016-06-09 04:16:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 04:58:00 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/36889c50c1e61023e78aa27e5876285d0d79cb25 Cr-Commit-Position: refs/heads/master@{#398790}
4 years, 6 months ago (2016-06-09 04:59:19 UTC) #12
Yuki
4 years, 6 months ago (2016-06-09 06:39:01 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698