Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: ui/views/controls/tree/tree_view.h

Issue 2050813002: MacViews: support backgrounds for selected rows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: excise depth Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/tree/tree_view.h
diff --git a/ui/views/controls/tree/tree_view.h b/ui/views/controls/tree/tree_view.h
index 2dc764e7f5688216ff6944f650fcb66feae0de1a..128e97849a717d0cd13c081e227928d53eb2de55 100644
--- a/ui/views/controls/tree/tree_view.h
+++ b/ui/views/controls/tree/tree_view.h
@@ -294,12 +294,15 @@ class VIEWS_EXPORT TreeView : public ui::TreeModelObserver,
ui::TreeModelNode* model_node,
GetInternalNodeCreateType create_type);
+ // Returns the bounds for a node's background.
+ gfx::Rect GetBackgroundBoundsForNode(InternalNode* node);
+
// Returns the bounds for a node.
tapted 2016/06/15 03:17:50 nit: update comment
Elly Fong-Jones 2016/06/16 14:42:34 Done.
- gfx::Rect GetBoundsForNode(InternalNode* node);
+ gfx::Rect GetTextBoundsForNode(InternalNode* node);
// Implementation of GetBoundsForNode. Separated out as some callers already
tapted 2016/06/15 03:17:50 nit: update comment
Elly Fong-Jones 2016/06/16 14:42:34 Done.
// know the row/depth.
- gfx::Rect GetBoundsForNodeImpl(InternalNode* node, int row, int depth);
+ gfx::Rect GetTextBoundsForNodeImpl(InternalNode* node, int row, int depth);
// Returns the row and depth of a node.
int GetRowForInternalNode(InternalNode* node, int* depth);
@@ -331,6 +334,14 @@ class VIEWS_EXPORT TreeView : public ui::TreeModelObserver,
PrefixSelector* GetPrefixSelector();
+ // This function returns the InternalNode (if any) lying under |point|. If no
tapted 2016/06/15 03:17:50 nit: remove "This function" / "this function".
Elly Fong-Jones 2016/06/16 14:42:34 Done.
+ // node lies under |point|, this function returns nullptr.
+ InternalNode* NodeAtPoint(const gfx::Point& point);
+
+ // This function returns whether |point| is in the bounds of |node|'s
tapted 2016/06/15 03:17:50 nit: Returns whether..
Elly Fong-Jones 2016/06/16 14:42:34 Done.
+ // expand/collapse arrow.
+ bool HitsNodeArrow(InternalNode* node, const gfx::Point& point);
+
// The model, may be null.
ui::TreeModel* model_;

Powered by Google App Engine
This is Rietveld 408576698