Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: build/gyp_environment.py

Issue 2050793002: ios: Default GYP_GENERATORS to ninja, and error out if GYP_GENERATORS is xcode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simpler Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/gyp_chromium.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """ 5 """
6 Sets up various automatic gyp environment variables. These are used by 6 Sets up various automatic gyp environment variables. These are used by
7 gyp_chromium and landmines.py which run at different stages of runhooks. To 7 gyp_chromium and landmines.py which run at different stages of runhooks. To
8 make sure settings are consistent between them, all setup should happen here. 8 make sure settings are consistent between them, all setup should happen here.
9 """ 9 """
10 10
11 import gyp_helper 11 import gyp_helper
12 import mac_toolchain 12 import mac_toolchain
13 import os 13 import os
14 import sys 14 import sys
15 import vs_toolchain 15 import vs_toolchain
16 16
17 def SetEnvironment(): 17 def SetEnvironment():
18 """Sets defaults for GYP_* variables.""" 18 """Sets defaults for GYP_* variables."""
19 gyp_helper.apply_chromium_gyp_env() 19 gyp_helper.apply_chromium_gyp_env()
20 20
21 # Default to ninja on linux and windows, but only if no generator has 21 # Default to ninja on linux and windows, but only if no generator has
22 # explicitly been set. 22 # explicitly been set.
23 # Also default to ninja on mac, but only when not building chrome/ios. 23 # Also default to ninja on mac, but only when not building chrome/ios.
24 # . -f / --format has precedence over the env var, no need to check for it 24 # . -f / --format has precedence over the env var, no need to check for it
25 # . set the env var only if it hasn't been set yet 25 # . set the env var only if it hasn't been set yet
26 # . chromium.gyp_env has been applied to os.environ at this point already 26 # . chromium.gyp_env has been applied to os.environ at this point already
27 if sys.platform.startswith(('linux', 'win', 'freebsd')) and \ 27 if sys.platform.startswith(('linux', 'win', 'freebsd', 'darwin')) and \
28 not os.environ.get('GYP_GENERATORS'): 28 not os.environ.get('GYP_GENERATORS'):
29 os.environ['GYP_GENERATORS'] = 'ninja' 29 os.environ['GYP_GENERATORS'] = 'ninja'
30 elif sys.platform == 'darwin' and not os.environ.get('GYP_GENERATORS') and \
31 not 'OS=ios' in os.environ.get('GYP_DEFINES', []):
32 os.environ['GYP_GENERATORS'] = 'ninja'
33 30
34 vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs() 31 vs_toolchain.SetEnvironmentAndGetRuntimeDllDirs()
35 mac_toolchain.SetToolchainEnvironment() 32 mac_toolchain.SetToolchainEnvironment()
OLDNEW
« no previous file with comments | « build/gyp_chromium.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698