Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Side by Side Diff: build/gyp_chromium.py

Issue 2050793002: ios: Default GYP_GENERATORS to ninja, and error out if GYP_GENERATORS is xcode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: simpler Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/gyp_environment.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """This script is wrapper for Chromium that adds some support for how GYP 5 """This script is wrapper for Chromium that adds some support for how GYP
6 is invoked by Chromium beyond what can be done in the gclient hooks. 6 is invoked by Chromium beyond what can be done in the gclient hooks.
7 """ 7 """
8 8
9 import argparse 9 import argparse
10 import gc 10 import gc
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
277 print 'Error: make gyp generator not supported (check GYP_GENERATORS).' 277 print 'Error: make gyp generator not supported (check GYP_GENERATORS).'
278 sys.exit(1) 278 sys.exit(1)
279 279
280 # We explicitly don't support the native msvs gyp generator. Be nice and 280 # We explicitly don't support the native msvs gyp generator. Be nice and
281 # fail here, rather than generating broken projects. 281 # fail here, rather than generating broken projects.
282 if re.search(r'(^|,|\s)msvs($|,|\s)', os.environ.get('GYP_GENERATORS', '')): 282 if re.search(r'(^|,|\s)msvs($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
283 print 'Error: msvs gyp generator not supported (check GYP_GENERATORS).' 283 print 'Error: msvs gyp generator not supported (check GYP_GENERATORS).'
284 print 'Did you mean to use the `msvs-ninja` generator?' 284 print 'Did you mean to use the `msvs-ninja` generator?'
285 sys.exit(1) 285 sys.exit(1)
286 286
287 # We explicitly don't support the native xcode gyp generator. Be nice and
288 # fail here, rather than generating broken projects.
289 if re.search(r'(^|,|\s)xcode($|,|\s)', os.environ.get('GYP_GENERATORS', '')):
290 print 'Error: xcode gyp generator not supported (check GYP_GENERATORS).'
291 print 'Did you mean to use the `xcode-ninja` generator?'
292 sys.exit(1)
293
287 # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check 294 # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
288 # to enfore syntax checking. 295 # to enfore syntax checking.
289 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK') 296 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
290 if syntax_check and int(syntax_check): 297 if syntax_check and int(syntax_check):
291 args.append('--check') 298 args.append('--check')
292 299
293 # TODO(dmikurube): Remove these checks and messages after a while. 300 # TODO(dmikurube): Remove these checks and messages after a while.
294 if ('linux_use_tcmalloc' in gyp_vars_dict or 301 if ('linux_use_tcmalloc' in gyp_vars_dict or
295 'android_use_tcmalloc' in gyp_vars_dict): 302 'android_use_tcmalloc' in gyp_vars_dict):
296 print '*****************************************************************' 303 print '*****************************************************************'
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 if vs2013_runtime_dll_dirs: 357 if vs2013_runtime_dll_dirs:
351 x64_runtime, x86_runtime = vs2013_runtime_dll_dirs 358 x64_runtime, x86_runtime = vs2013_runtime_dll_dirs
352 vs_toolchain.CopyVsRuntimeDlls( 359 vs_toolchain.CopyVsRuntimeDlls(
353 os.path.join(chrome_src, GetOutputDirectory()), 360 os.path.join(chrome_src, GetOutputDirectory()),
354 (x86_runtime, x64_runtime)) 361 (x86_runtime, x64_runtime))
355 362
356 sys.exit(gyp_rc) 363 sys.exit(gyp_rc)
357 364
358 if __name__ == '__main__': 365 if __name__ == '__main__':
359 sys.exit(main()) 366 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | build/gyp_environment.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698