Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Unified Diff: build/config/gcc/BUILD.gn

Issue 2050763004: Ensure that chrome_sandbox doesn't have -rpath=$ORIGIN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sandbox/linux/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/gcc/BUILD.gn
diff --git a/build/config/gcc/BUILD.gn b/build/config/gcc/BUILD.gn
index 62eec11904ac93b8cf26f75e76796c0881559dcd..422ec0e92af9173212fe8eeec091a359f4f9b178 100644
--- a/build/config/gcc/BUILD.gn
+++ b/build/config/gcc/BUILD.gn
@@ -71,6 +71,10 @@ config("rpath_for_built_shared_libraries") {
# Settings for executables.
config("executable_ldconfig") {
+ # WARNING! //sandbox/linux:chrome_sandbox will not pick up this
+ # config, because it is a setuid binary that needs special flags.
+ # If you add things to this config, make sure you check to see
+ # if they should be added to that target as well.
Dirk Pranke 2016/06/09 00:41:49 In theory I could split this out into two configs
ldflags = []
if (is_android) {
ldflags += [
« no previous file with comments | « no previous file | sandbox/linux/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698