Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2050763003: Dart: Add warning to the top of .mojom.dart files (Closed)

Created:
4 years, 6 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -393 lines) Patch
M mojo/dart/packages/_mojo_for_test_only/lib/dart_to_cpp/dart_to_cpp.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/imported/sample_import2.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/math/math_calculator.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/examples/echo.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/rect.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/serialization_test_structs.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_enums.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_included_unions.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_structs.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/test_unions.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/validation_test_interfaces.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/mojo/test/versioning/versioning_test_client.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/regression_tests/regression_tests.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_factory.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_interfaces.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/sample/sample_service.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/application_connector.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_files.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/bindings/types/service_describer.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/http_header.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/interface_control_messages.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/network_error.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/service_provider.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/shell.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/url_request.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo/lib/mojo/url_response.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/activity/activity.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/authentication/authentication.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/authentication/authentication_admin.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/authentication/authentication_impl_db.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/contacts/contacts.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_request.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_response.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_server.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/http_server/http_server_factory.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/icu_data/icu_data.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/input/input.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/keyboard/keyboard.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/asset_bundle/asset_bundle.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/authenticating_url_loader_interceptor_meta_factory.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/camera.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/clipboard.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/content_handler.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/cookie_store.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/device_info.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/directory.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/file.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/files.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/ioctl.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/ioctl_terminal.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/files/types.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/flog/flog.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/geocoder.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/geometry.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/compositor.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/hit_tests.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/nodes.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/renderers.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/resources.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scene_token.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scenes.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/scheduling.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/host_resolver.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/http_connection.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/http_message.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/http_server.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/input_event_constants.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/input_events.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/input_key_codes.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/location.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/location_service.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_server.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_common.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_demux.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_factory.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_metadata.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_player.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_sink.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_source.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_transport.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_type_converter.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_types.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/seeking_reader.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/timeline_controller.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/native_viewport_event_dispatcher.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/navigation.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/net_address.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/network_service.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/quads.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/service_registry.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/sharing.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/surface_id.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/surfaces.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_bound_socket.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_connected_socket.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/tcp_server_socket.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/terminal/terminal.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/terminal/terminal_client.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/timelines.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/udp_socket.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/input_connection.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/input_dispatcher.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_associates.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_containers.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_manager.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_properties.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_provider.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_token.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_tree_token.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/view_trees.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/ui/views.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_loader.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_loader_interceptor.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/url_response_disk_cache.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/web_socket.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/native_support/process.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/nfc/nfc.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/notifications/notifications.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/prediction/prediction.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/sensors/sensors.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/speech_recognizer/speech_recognizer.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/tracing/trace_provider_registry.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/tracing/tracing.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/vsync/vsync.mojom.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
Only change is in: https://codereview.chromium.org/2050763003/diff/1/mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl
4 years, 6 months ago (2016-06-08 18:26:27 UTC) #2
Cutch
lgtm
4 years, 6 months ago (2016-06-08 22:56:19 UTC) #3
zra
4 years, 6 months ago (2016-06-09 16:19:28 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
39dc61b66fffdb0a1ce49600b1f76bdb4d065bbe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698