Issue 205073002: Use rounding to 8888 in lighting filters, raster path.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205073002: Use rounding to 8888 in lighting filters, raster path. (Closed)

Created:
6 years, 9 months ago by Stephen White

Modified:
6 years, 9 months ago

Reviewers:
Justin Novosad

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Use rounding to 8888 in lighting filters, raster path. when converting float -> 8-bit BGRA in lighting filters, use rounding rather than floor(). This makes the GPU and raster paths match more closely (as tested by Blink test feDiffuseLighting-linearrgb-lighting-color.svg). Will affect the LSB of lighting, imagefiltersscaled GMs. R=junov@chromium.org BUG=skia: Committed: https://code.google.com/p/skia/source/detail?r=13863

Patch Set 1 #

Patch Set 2 : Fix expectations #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
	M	src/effects/SkLightingImageFilter.cpp	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Justin Novosad

On 2014/03/19 19:28:37, Stephen White wrote: > junov@: PTAL. Thanks! lgtm

6 years, 9 months ago (2014-03-19 19:40:22 UTC) #2

Stephen White

6 years, 9 months ago (2014-03-19 19:44:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r13863 (presubmit successful).

Expand Messages | Collapse Messages