Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2050713002: [--prof] Adding support for RuntimeCallTimerScope based tick separation (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[--prof] Adding support for RuntimeCallTimerScope based tick separation BUG= Committed: https://crrev.com/01a423e00f571c93eac369386a343621c7f82b61 Cr-Commit-Position: refs/heads/master@{#36883}

Patch Set 1 #

Patch Set 2 : reverting flag changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M src/counters.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/counters.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/log.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/log.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M tools/tickprocessor.js View 6 chunks +20 lines, -3 lines 0 comments Download
M tools/tickprocessor-driver.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Camillo Bruni
PTAL
4 years, 6 months ago (2016-06-09 07:40:04 UTC) #2
Yang
On 2016/06/09 07:40:04, Camillo Bruni wrote: > PTAL lgtm
4 years, 6 months ago (2016-06-09 08:47:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050713002/1
4 years, 6 months ago (2016-06-09 11:42:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/2889) v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-09 12:02:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050713002/1
4 years, 6 months ago (2016-06-09 14:14:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng/builds/2985) v8_win_nosnap_shared_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-09 14:31:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050713002/20001
4 years, 6 months ago (2016-06-10 08:42:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 09:16:11 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 09:16:54 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/01a423e00f571c93eac369386a343621c7f82b61
Cr-Commit-Position: refs/heads/master@{#36883}

Powered by Google App Engine
This is Rietveld 408576698