HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no `download` yet).

BUG=605552
Committed: https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5
Cr-Commit-Position: refs/heads/master@{#406541}

[Anton Obzhirov, 2016-06-08 12:27:16]

Description was changed from

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552
==========

to

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552
==========

[Anton Obzhirov, 2016-06-08 12:27:16]

a.obzhirov@samsung.com changed reviewers:
+ dominicc@chromium.org

[Anton Obzhirov, 2016-06-08 12:27:56]

On 2016/06/08 12:27:16, a.obzhirov wrote:
> mailto:a.obzhirov@samsung.com changed reviewers:
> + mailto:dominicc@chromium.org

Hi, plz have a look.

[dominicc (has gone to gerrit), 2016-06-09 07:59:32]

On 2016/06/08 at 12:27:56, a.obzhirov wrote:
> On 2016/06/08 12:27:16, a.obzhirov wrote:
> > mailto:a.obzhirov@samsung.com changed reviewers:
> > + mailto:dominicc@chromium.org
> 
> Hi, plz have a look.

This is a good start. Now there's the semantics:

https://html.spec.whatwg.org/multipage/semantics.html#downloading-hyperlinks

Searching for code which uses HTMLNames::downloadAttr may help you uncover what
needs to hook into this.

Please add a test,
LayoutTests/http/tests/security/anchor-download-allow-data.html might provide
some inspiration.

[Anton Obzhirov, 2016-06-09 16:56:37]

On 2016/06/09 07:59:32, dominicc wrote:
> On 2016/06/08 at 12:27:56, a.obzhirov wrote:
> > On 2016/06/08 12:27:16, a.obzhirov wrote:
> > > mailto:a.obzhirov@samsung.com changed reviewers:
> > > + mailto:dominicc@chromium.org
> > 
> > Hi, plz have a look.
> 
> This is a good start. Now there's the semantics:
> 
> https://html.spec.whatwg.org/multipage/semantics.html#downloading-hyperlinks
> 
> Searching for code which uses HTMLNames::downloadAttr may help you uncover
what
> needs to hook into this.
> 
> Please add a test,
> LayoutTests/http/tests/security/anchor-download-allow-data.html might provide
> some inspiration.

Thanks,
it seems like it is already hooked through HTMLAnchorElement (See
HTMLAnchorElement::defaultEventHandler).
But probably there are other bits missing. Will check and add new test.

[Anton Obzhirov, 2016-06-20 13:58:37]

On 2016/06/09 16:56:37, Anton Obzhirov wrote:
> On 2016/06/09 07:59:32, dominicc wrote:
> > On 2016/06/08 at 12:27:56, a.obzhirov wrote:
> > > On 2016/06/08 12:27:16, a.obzhirov wrote:
> > > > mailto:a.obzhirov@samsung.com changed reviewers:
> > > > + mailto:dominicc@chromium.org
> > > 
> > > Hi, plz have a look.
> > 
> > This is a good start. Now there's the semantics:
> > 
> > https://html.spec.whatwg.org/multipage/semantics.html#downloading-hyperlinks
> > 
> > Searching for code which uses HTMLNames::downloadAttr may help you uncover
> what
> > needs to hook into this.
> > 
> > Please add a test,
> > LayoutTests/http/tests/security/anchor-download-allow-data.html might
provide
> > some inspiration.
> 
> Thanks,
> it seems like it is already hooked through HTMLAnchorElement (See
> HTMLAnchorElement::defaultEventHandler).
> But probably there are other bits missing. Will check and add new test.

Hi, I've added layout test for download attribute. Plz have a look. I made
search for downloadAttr and relAttr,
it should be handled in HTMLAnchorElement already for HTMLAreaElement.

[dominicc (has gone to gerrit), 2016-06-23 04:20:19]

This looks really nice, thank you. One minor nit inline then LGTM.

https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html
(right):

https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html:13:
<area id="area" download="blob" shape="rect" coords="0, 0, 100, 100">
Could we make this a different string, since 'blob' is the name of something in
the web platform, and you're using a blob, etc.? foo or something is fine :) It
will make it clearer that this sets the name of the downloaded thing.

[Anton Obzhirov, 2016-06-23 12:09:52]

On 2016/06/23 04:20:19, dominicc wrote:
> This looks really nice, thank you. One minor nit inline then LGTM.
> 
>
https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
> File
third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html
> (right):
> 
>
https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html:13:
> <area id="area" download="blob" shape="rect" coords="0, 0, 100, 100">
> Could we make this a different string, since 'blob' is the name of something
in
> the web platform, and you're using a blob, etc.? foo or something is fine :)
It
> will make it clearer that this sets the name of the downloaded thing.

NP

[Anton Obzhirov, 2016-06-23 14:08:36]

On 2016/06/23 12:09:52, Anton Obzhirov wrote:
> On 2016/06/23 04:20:19, dominicc wrote:
> > This looks really nice, thank you. One minor nit inline then LGTM.
> > 
> >
>
https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
> > File
> third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html
> > (right):
> > 
> >
>
https://codereview.chromium.org/2050643002/diff/20001/third_party/WebKit/Layo...
> >
third_party/WebKit/LayoutTests/fast/dom/HTMLAreaElement/area-download.html:13:
> > <area id="area" download="blob" shape="rect" coords="0, 0, 100, 100">
> > Could we make this a different string, since 'blob' is the name of something
> in
> > the web platform, and you're using a blob, etc.? foo or something is fine :)
> It
> > will make it clearer that this sets the name of the downloaded thing.
> 
> NP

Done :)

[dominicc (has gone to gerrit), 2016-06-28 03:14:19]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-06-28 03:14:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2050643002/#ps40001
(title: "Cleanup.")

[commit-bot: I haz the power, 2016-06-28 03:14:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 03:21:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 03:21:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dominicc (has gone to gerrit), 2016-06-28 03:38:47]

dominicc@chromium.org changed reviewers:
+ tkent@chromium.org

[dominicc (has gone to gerrit), 2016-06-28 03:39:09]

On 2016/06/28 at 03:21:35, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

+tkent for API owners approval for the virtual/webexposed tests.

[tkent, 2016-06-28 03:49:33]

This change has no risk, and we may skip intent-to-ship.
Please make an entry in https://www.chromestatus.com/features

[Anton Obzhirov, 2016-06-28 11:00:08]

On 2016/06/28 03:49:33, tkent wrote:
> This change has no risk, and we may skip intent-to-ship.
> Please make an entry in https://www.chromestatus.com/features

Hi, I don't think I have access to edit https://www.chromestatus.com/features.
How is it supposed to be updated usually?

[tkent, 2016-06-28 22:56:00]

On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> On 2016/06/28 03:49:33, tkent wrote:
> > This change has no risk, and we may skip intent-to-ship.
> > Please make an entry in https://www.chromestatus.com/features
> 
> Hi, I don't think I have access to edit https://www.chromestatus.com/features.
How is it supposed to be updated usually?

There is 'Request "edit" access' link at the bottom of the page.

[Anton Obzhirov, 2016-06-30 12:48:57]

On 2016/06/28 22:56:00, tkent wrote:
> On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > On 2016/06/28 03:49:33, tkent wrote:
> > > This change has no risk, and we may skip intent-to-ship.
> > > Please make an entry in https://www.chromestatus.com/features
> > 
> > Hi, I don't think I have access to edit
https://www.chromestatus.com/features.
> How is it supposed to be updated usually?
> 
> There is 'Request "edit" access' link at the bottom of the page.

Thanks, I sent the request yesterday, now waiting.

[dominicc (has gone to gerrit), 2016-07-13 07:08:11]

On 2016/06/30 at 12:48:57, a.obzhirov wrote:
> On 2016/06/28 22:56:00, tkent wrote:
> > On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > > On 2016/06/28 03:49:33, tkent wrote:
> > > > This change has no risk, and we may skip intent-to-ship.
> > > > Please make an entry in https://www.chromestatus.com/features
> > > 
> > > Hi, I don't think I have access to edit
https://www.chromestatus.com/features.
> > How is it supposed to be updated usually?
> > 
> > There is 'Request "edit" access' link at the bottom of the page.
> 
> Thanks, I sent the request yesterday, now waiting.

Hi a.obzhirov, what's the status of this? Did you get access?

[Anton Obzhirov, 2016-07-13 12:14:33]

On 2016/07/13 07:08:11, dominicc wrote:
> On 2016/06/30 at 12:48:57, a.obzhirov wrote:
> > On 2016/06/28 22:56:00, tkent wrote:
> > > On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > > > On 2016/06/28 03:49:33, tkent wrote:
> > > > > This change has no risk, and we may skip intent-to-ship.
> > > > > Please make an entry in https://www.chromestatus.com/features
> > > > 
> > > > Hi, I don't think I have access to edit
> https://www.chromestatus.com/features.
> > > How is it supposed to be updated usually?
> > > 
> > > There is 'Request "edit" access' link at the bottom of the page.
> > 
> > Thanks, I sent the request yesterday, now waiting.
> 
> Hi a.obzhirov, what's the status of this? Did you get access?

Hi, not yet. Somehow my request was ignored. I've just sent another one. May be
you guys
could check it on your side to see if it is coming through?

[dominicc (has gone to gerrit), 2016-07-15 06:08:11]

I've pinged someone about it. Sorry it's taking so long.

On Wed, Jul 13, 2016 at 9:14 PM, <a.obzhirov@samsung.com> wrote:

> On 2016/07/13 07:08:11, dominicc wrote:
> > On 2016/06/30 at 12:48:57, a.obzhirov wrote:
> > > On 2016/06/28 22:56:00, tkent wrote:
> > > > On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > > > > On 2016/06/28 03:49:33, tkent wrote:
> > > > > > This change has no risk, and we may skip intent-to-ship.
> > > > > > Please make an entry in https://www.chromestatus.com/features
> > > > >
> > > > > Hi, I don't think I have access to edit
> > https://www.chromestatus.com/features.
> > > > How is it supposed to be updated usually?
> > > >
> > > > There is 'Request "edit" access' link at the bottom of the page.
> > >
> > > Thanks, I sent the request yesterday, now waiting.
> >
> > Hi a.obzhirov, what's the status of this? Did you get access?
>
> Hi, not yet. Somehow my request was ignored. I've just sent another one.
> May be
> you guys
> could check it on your side to see if it is coming through?
>
> https://codereview.chromium.org/2050643002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[dominicc (has gone to gerrit), 2016-07-15 06:08:12]

I've pinged someone about it. Sorry it's taking so long.

On Wed, Jul 13, 2016 at 9:14 PM, <a.obzhirov@samsung.com> wrote:

> On 2016/07/13 07:08:11, dominicc wrote:
> > On 2016/06/30 at 12:48:57, a.obzhirov wrote:
> > > On 2016/06/28 22:56:00, tkent wrote:
> > > > On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > > > > On 2016/06/28 03:49:33, tkent wrote:
> > > > > > This change has no risk, and we may skip intent-to-ship.
> > > > > > Please make an entry in https://www.chromestatus.com/features
> > > > >
> > > > > Hi, I don't think I have access to edit
> > https://www.chromestatus.com/features.
> > > > How is it supposed to be updated usually?
> > > >
> > > > There is 'Request "edit" access' link at the bottom of the page.
> > >
> > > Thanks, I sent the request yesterday, now waiting.
> >
> > Hi a.obzhirov, what's the status of this? Did you get access?
>
> Hi, not yet. Somehow my request was ignored. I've just sent another one.
> May be
> you guys
> could check it on your side to see if it is coming through?
>
> https://codereview.chromium.org/2050643002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Anton Obzhirov, 2016-07-19 10:52:49]

On 2016/07/15 06:08:12, dominicc wrote:
> I've pinged someone about it. Sorry it's taking so long.
> 
> On Wed, Jul 13, 2016 at 9:14 PM, <mailto:a.obzhirov@samsung.com> wrote:
> 
> > On 2016/07/13 07:08:11, dominicc wrote:
> > > On 2016/06/30 at 12:48:57, a.obzhirov wrote:
> > > > On 2016/06/28 22:56:00, tkent wrote:
> > > > > On 2016/06/28 at 11:00:08, a.obzhirov wrote:
> > > > > > On 2016/06/28 03:49:33, tkent wrote:
> > > > > > > This change has no risk, and we may skip intent-to-ship.
> > > > > > > Please make an entry in https://www.chromestatus.com/features
> > > > > >
> > > > > > Hi, I don't think I have access to edit
> > > https://www.chromestatus.com/features.
> > > > > How is it supposed to be updated usually?
> > > > >
> > > > > There is 'Request "edit" access' link at the bottom of the page.
> > > >
> > > > Thanks, I sent the request yesterday, now waiting.
> > >
> > > Hi a.obzhirov, what's the status of this? Did you get access?
> >
> > Hi, not yet. Somehow my request was ignored. I've just sent another one.
> > May be
> > you guys
> > could check it on your side to see if it is coming through?
> >
> > https://codereview.chromium.org/2050643002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Finally got access, thanks!
Added entry, plz have a look.
https://www.chromestatus.com/features/5723126851698688

[tkent, 2016-07-19 23:18:48]

lgtm.  Thank you!

https://codereview.chromium.org/2050643002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLAreaElement.idl (right):

https://codereview.chromium.org/2050643002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLAreaElement.idl:32: // FIXME: relList
are missing
are -> is

[Anton Obzhirov, 2016-07-20 09:31:55]

On 2016/07/19 23:18:48, tkent wrote:
> lgtm.  Thank you!
> 
>
https://codereview.chromium.org/2050643002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/HTMLAreaElement.idl (right):
> 
>
https://codereview.chromium.org/2050643002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/HTMLAreaElement.idl:32: // FIXME: relList
> are missing
> are -> is

Remains of previous comment :). Fill fix now and upload the final version.

[Anton Obzhirov, 2016-07-20 10:51:53]

The CQ bit was checked by a.obzhirov@samsung.com

[Anton Obzhirov, 2016-07-20 10:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
dominicc@chromium.org
Link to the patchset: https://codereview.chromium.org/2050643002/#ps60001
(title: "Final version")

[commit-bot: I haz the power, 2016-07-20 10:52:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 13:07:00]

Description was changed from

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552
==========

to

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552
==========

[commit-bot: I haz the power, 2016-07-20 13:07:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-20 13:07:10]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 13:09:58]

Description was changed from

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552
==========

to

==========
HTMLAreaElement should expose `download` and `rel` attributes.

HTMLAreaElement should define IDL `download` and `rel` attributes for faster
access.
Firefox implements both of them, Safari/Edge has only `rel` (WebKit has no
`download` yet).

BUG=605552

Committed: https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5
Cr-Commit-Position: refs/heads/master@{#406541}
==========

[commit-bot: I haz the power, 2016-07-20 13:09:59]

Patchset 4 (id:??) landed as
https://crrev.com/0bf0830d9b2964a57c2fceced5e873b31d8f91d5
Cr-Commit-Position: refs/heads/master@{#406541}