Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some cleanup. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/web/WebFrameClient.h
diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h
index f1cbdba6c78c81eed9cfbe33650100ca06590566..81f40f5d3a74e6f35d73c2c68b72a3c4444bc328 100644
--- a/third_party/WebKit/public/web/WebFrameClient.h
+++ b/third_party/WebKit/public/web/WebFrameClient.h
@@ -35,6 +35,7 @@
#include "WebAXObject.h"
#include "WebDOMMessageEvent.h"
#include "WebDataSource.h"
+#include "WebFileChooserParams.h"
#include "WebFrame.h"
#include "WebFrameOwnerProperties.h"
#include "WebHistoryCommitType.h"
@@ -438,6 +439,13 @@ public:
// the user selects 'OK' or false otherwise.
virtual bool runModalBeforeUnloadDialog(bool isReload) { return true; }
+ // This method returns immediately after showing the dialog. When the
+ // dialog is closed, it should call the WebFileChooserCompletion to
+ // pass the results of the dialog. Returns false if
+ // WebFileChooseCompletion will never be called.
+ virtual bool runFileChooser(
+ const blink::WebFileChooserParams& params,
+ WebFileChooserCompletion* chooserCompletion) { return false; }
dcheng 2016/06/10 21:43:35 Technically I think you need to include or forward
nasko 2016/06/10 22:07:50 Done.
// UI ------------------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698