components/test_runner/web_view_test_client.cc - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_view_test_client.cc

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Some cleanup. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/web_view_test_client.h ('k') | content/browser/frame_host/render_frame_host_delegate.h » ('j') | content/browser/frame_host/render_frame_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_view_test_client.cc

diff --git a/components/test_runner/web_view_test_client.cc b/components/test_runner/web_view_test_client.cc

index b52af0b09ed4d30ab051b729a1e244d87d196cd3..3c71df27eb09ff0310f471bf451551cb24b33be2 100644

--- a/components/test_runner/web_view_test_client.cc

+++ b/components/test_runner/web_view_test_client.cc

@@ -103,14 +103,6 @@ void WebViewTestClient::printPage(blink::WebLocalFrame* frame) {

frame->printEnd();

}

-bool WebViewTestClient::runFileChooser(

- const blink::WebFileChooserParams& params,

- blink::WebFileChooserCompletion* completion) {

- delegate()->PrintMessage("Mock: Opening a file chooser.\n");

- // FIXME: Add ability to set file names to a file upload control.

- return false;

void WebViewTestClient::showValidationMessage(

const blink::WebRect& anchor_in_root_view,

const blink::WebString& main_message,