Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/public/web/WebViewClient.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on reviews. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebViewClient.h
diff --git a/third_party/WebKit/public/web/WebViewClient.h b/third_party/WebKit/public/web/WebViewClient.h
index 02ecea288f6e263178bb3fdd28dac1b96c5642d6..48dec294fec51b1cfd16e2a221c23c86132baba0 100644
--- a/third_party/WebKit/public/web/WebViewClient.h
+++ b/third_party/WebKit/public/web/WebViewClient.h
@@ -36,8 +36,6 @@
#include "../platform/WebString.h"
#include "WebAXEnums.h"
#include "WebContentDetectionResult.h"
-#include "WebFileChooserCompletion.h"
-#include "WebFileChooserParams.h"
#include "WebFrame.h"
#include "WebPopupType.h"
#include "WebTextDirection.h"
@@ -134,13 +132,6 @@ public:
// Dialogs -------------------------------------------------------------
- // This method returns immediately after showing the dialog. When the
- // dialog is closed, it should call the WebFileChooserCompletion to
- // pass the results of the dialog. Returns false if
- // WebFileChooseCompletion will never be called.
- virtual bool runFileChooser(const WebFileChooserParams&,
- WebFileChooserCompletion*) { return false; }
-
// Ask users to choose date/time for the specified parameters. When a user
// chooses a value, an implementation of this function should call
// WebDateTimeChooserCompletion::didChooseValue or didCancelChooser. If the
« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698