third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index d8f04151bddc84bc5ac5c6fab3de38736d419ee5..fa6f8d8b5af5517156e6f291626a60a4c6e0fa8c 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -684,7 +684,7 @@ DateTimeChooser* ChromeClientImpl::openDateTimeChooser(DateTimeChooserClient* pi

void ChromeClientImpl::openFileChooser(LocalFrame* frame, PassRefPtr<FileChooser> fileChooser)

{

notifyPopupOpeningObservers();

- WebViewClient* client = m_webView->client();

+ WebFrameClient* client = WebLocalFrameImpl::fromFrame(frame)->client();

if (!client)

return;

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/public/web/WebFrameClient.h » ('j') | no next file with comments »