content/renderer/pepper/pepper_file_chooser_host.cc - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_file_chooser_host.cc

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/mock_renderer_ppapi_host.cc ('k') | content/renderer/pepper/pepper_file_chooser_host_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_file_chooser_host.cc

diff --git a/content/renderer/pepper/pepper_file_chooser_host.cc b/content/renderer/pepper/pepper_file_chooser_host.cc

index b70ab83c3d14241ca2270adb4256d0d3accef604..f2f8be3b2e57fa5ff2b060c9051a9007b7bedf0d 100644

--- a/content/renderer/pepper/pepper_file_chooser_host.cc

+++ b/content/renderer/pepper/pepper_file_chooser_host.cc

@@ -154,9 +154,10 @@ int32_t PepperFileChooserHost::OnShow(

params.requestor = renderer_ppapi_host_->GetDocumentURL(pp_instance());

handler_ = new CompletionHandler(AsWeakPtr());

- RenderViewImpl* render_view = static_cast<RenderViewImpl*>(

- renderer_ppapi_host_->GetRenderViewForInstance(pp_instance()));

- if (!render_view || !render_view->runFileChooser(params, handler_)) {

+ RenderFrameImpl* render_frame = static_cast<RenderFrameImpl*>(

+ renderer_ppapi_host_->GetRenderFrameForInstance(pp_instance()));

+ if (!render_frame || !render_frame->runFileChooser(params, handler_)) {

delete handler_;

handler_ = NULL;

return PP_ERROR_NOACCESS;