content/browser/web_contents/web_contents_impl.h - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 124875ee29ed77843b93d2cc88d5e077c08f627f..4cc0c5bc1e2e1d7013ff2b7530738a287958566f 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -428,6 +428,8 @@ class CONTENT_EXPORT WebContentsImpl

void RunBeforeUnloadConfirm(RenderFrameHost* render_frame_host,

bool is_reload,

IPC::Message* reply_msg) override;

+ void RunFileChooser(RenderFrameHost* render_frame_host,

+ const FileChooserParams& params) override;

void DidAccessInitialDocument() override;

void DidChangeName(RenderFrameHost* render_frame_host,

const std::string& name) override;

@@ -496,8 +498,6 @@ class CONTENT_EXPORT WebContentsImpl

uint64_t upload_position,

uint64_t upload_size) override;

void Activate() override;

- void RunFileChooser(RenderViewHost* render_view_host,

- const FileChooserParams& params) override;

void UpdatePreferredSize(const gfx::Size& pref_size) override;

void CreateNewWindow(

SiteInstance* source_site_instance,

« no previous file with comments | « content/browser/security_exploit_browsertest.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »