content/browser/renderer_host/render_view_host_impl.h - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_view_host_delegate.h ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 174d0ad7731cc356ae3502546a5025395062ef24..d2ff69b09bb0563c269cd749b2db29737c0b5b1b 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -133,9 +133,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

void ExecutePluginActionAtLocation(

const gfx::Point& location,

const blink::WebPluginAction& action) override;

- void FilesSelectedInChooser(

- const std::vector<FileChooserFileInfo>& files,

- FileChooserParams::Mode permissions) override;

RenderViewHostDelegate* GetDelegate() const override;

int GetEnabledBindings() const override;

SiteInstanceImpl* GetSiteInstance() const override;

@@ -302,7 +299,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

const gfx::Rect& node_bounds_in_viewport);

void OnClosePageACK();

void OnDidZoomURL(double zoom_level, const GURL& url);

- void OnRunFileChooser(const FileChooserParams& params);

void OnFocusedNodeTouched(bool editable);

void OnFocus();