components/test_runner/web_frame_test_client.h - Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_frame_test_client.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes based on reviews. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/web_frame_test_client.h

diff --git a/components/test_runner/web_frame_test_client.h b/components/test_runner/web_frame_test_client.h

index 86f624e32b67e90788badd27d1a8b7f31659e514..ed81b726159a60553c28590ab1e70f40753d5244 100644

--- a/components/test_runner/web_frame_test_client.h

+++ b/components/test_runner/web_frame_test_client.h

@@ -106,6 +106,8 @@ class WebFrameTestClient : public blink::WebFrameClient {

const blink::WebSecurityOrigin& security_origin,

blink::WebSetSinkIdCallbacks* web_callbacks) override;

void didClearWindowObject(blink::WebLocalFrame* frame) override;

+ bool runFileChooser(const blink::WebFileChooserParams& params,

+ blink::WebFileChooserCompletion* completion) override;

private:

// Borrowed pointers to other parts of Layout Tests state.

« no previous file with comments | « no previous file | components/test_runner/web_frame_test_client.cc » ('j') | no next file with comments »