Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2050623005: Move file chooser from RenderView(Host) to RenderFrame(Host). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some cleanup. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 void EnableAutoResize(const gfx::Size& min_size, 126 void EnableAutoResize(const gfx::Size& min_size,
127 const gfx::Size& max_size) override; 127 const gfx::Size& max_size) override;
128 void DisableAutoResize(const gfx::Size& new_size) override; 128 void DisableAutoResize(const gfx::Size& new_size) override;
129 void EnablePreferredSizeMode() override; 129 void EnablePreferredSizeMode() override;
130 void ExecuteMediaPlayerActionAtLocation( 130 void ExecuteMediaPlayerActionAtLocation(
131 const gfx::Point& location, 131 const gfx::Point& location,
132 const blink::WebMediaPlayerAction& action) override; 132 const blink::WebMediaPlayerAction& action) override;
133 void ExecutePluginActionAtLocation( 133 void ExecutePluginActionAtLocation(
134 const gfx::Point& location, 134 const gfx::Point& location,
135 const blink::WebPluginAction& action) override; 135 const blink::WebPluginAction& action) override;
136 void FilesSelectedInChooser(
137 const std::vector<FileChooserFileInfo>& files,
138 FileChooserParams::Mode permissions) override;
139 RenderViewHostDelegate* GetDelegate() const override; 136 RenderViewHostDelegate* GetDelegate() const override;
140 int GetEnabledBindings() const override; 137 int GetEnabledBindings() const override;
141 SiteInstanceImpl* GetSiteInstance() const override; 138 SiteInstanceImpl* GetSiteInstance() const override;
142 bool IsRenderViewLive() const override; 139 bool IsRenderViewLive() const override;
143 void NotifyMoveOrResizeStarted() override; 140 void NotifyMoveOrResizeStarted() override;
144 void SetWebUIProperty(const std::string& name, 141 void SetWebUIProperty(const std::string& name,
145 const std::string& value) override; 142 const std::string& value) override;
146 void Zoom(PageZoom zoom) override; 143 void Zoom(PageZoom zoom) override;
147 void SyncRendererPrefs() override; 144 void SyncRendererPrefs() override;
148 WebPreferences GetWebkitPreferences() override; 145 WebPreferences GetWebkitPreferences() override;
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 blink::WebDragOperationsMask operations_allowed, 292 blink::WebDragOperationsMask operations_allowed,
296 const SkBitmap& bitmap, 293 const SkBitmap& bitmap,
297 const gfx::Vector2d& bitmap_offset_in_dip, 294 const gfx::Vector2d& bitmap_offset_in_dip,
298 const DragEventSourceInfo& event_info); 295 const DragEventSourceInfo& event_info);
299 void OnUpdateDragCursor(blink::WebDragOperation drag_operation); 296 void OnUpdateDragCursor(blink::WebDragOperation drag_operation);
300 void OnTakeFocus(bool reverse); 297 void OnTakeFocus(bool reverse);
301 void OnFocusedNodeChanged(bool is_editable_node, 298 void OnFocusedNodeChanged(bool is_editable_node,
302 const gfx::Rect& node_bounds_in_viewport); 299 const gfx::Rect& node_bounds_in_viewport);
303 void OnClosePageACK(); 300 void OnClosePageACK();
304 void OnDidZoomURL(double zoom_level, const GURL& url); 301 void OnDidZoomURL(double zoom_level, const GURL& url);
305 void OnRunFileChooser(const FileChooserParams& params);
306 void OnFocusedNodeTouched(bool editable); 302 void OnFocusedNodeTouched(bool editable);
307 void OnFocus(); 303 void OnFocus();
308 304
309 private: 305 private:
310 // TODO(nasko): Temporarily friend RenderFrameHostImpl, so we don't duplicate 306 // TODO(nasko): Temporarily friend RenderFrameHostImpl, so we don't duplicate
311 // utility functions and state needed in both classes, while we move frame 307 // utility functions and state needed in both classes, while we move frame
312 // specific code away from this class. 308 // specific code away from this class.
313 friend class RenderFrameHostImpl; 309 friend class RenderFrameHostImpl;
314 friend class TestRenderViewHost; 310 friend class TestRenderViewHost;
315 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost); 311 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost);
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 bool render_view_ready_on_process_launch_; 402 bool render_view_ready_on_process_launch_;
407 403
408 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 404 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
409 405
410 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 406 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
411 }; 407 };
412 408
413 } // namespace content 409 } // namespace content
414 410
415 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 411 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698