ui/views/cocoa/bridged_content_view.mm - Issue 2050583002: BridgedContentView: Modify IsTextRTL to use GetFirstStrongCharacterDirection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/cocoa/bridged_content_view.mm

Issue 2050583002: BridgedContentView: Modify IsTextRTL to use GetFirstStrongCharacterDirection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/cocoa/bridged_content_view.mm

diff --git a/ui/views/cocoa/bridged_content_view.mm b/ui/views/cocoa/bridged_content_view.mm

index 6ac88de64c72dcb1373ce97d30a78853c51cc7cf..7fe03cabdef92cc789699397a56e080bc203f291 100644

--- a/ui/views/cocoa/bridged_content_view.mm

+++ b/ui/views/cocoa/bridged_content_view.mm

@@ -88,7 +88,8 @@ bool IsTextRTL(const ui::TextInputClient* client) {

base::string16 text;

return client && client->GetTextRange(&text_range) &&

client->GetTextFromRange(text_range, &text) &&

- base::i18n::GetStringDirection(text) == base::i18n::RIGHT_TO_LEFT;

+ base::i18n::GetFirstStrongCharacterDirection(text) ==

+ base::i18n::RIGHT_TO_LEFT;

}

// Returns the boundary rectangle for composition characters in the

« no previous file with comments | « no previous file | ui/views/controls/textfield/textfield_unittest.cc » ('j') | no next file with comments »