Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2050573003: Issue 26629. Detect cache inconsistency in GetContentTask. (Closed)

Created:
4 years, 6 months ago by scheglov
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 26629. Detect cache inconsistency in GetContentTask. When it is detected, invalidate the outputs and throw an exception to let Driver know that it should to recover. R=brianwilkerson@google.com, paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/26629 Committed: https://github.com/dart-lang/sdk/commit/979543e3a8356ef7c775a689613278c5ea7e3101

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -29 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 2 chunks +22 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 2 chunks +18 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/task/general.dart View 2 chunks +28 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +14 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/context/context_test.dart View 4 chunks +63 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 6 months ago (2016-06-08 22:11:48 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2050573003/diff/1/pkg/analyzer/lib/task/model.dart File pkg/analyzer/lib/task/model.dart (right): https://codereview.chromium.org/2050573003/diff/1/pkg/analyzer/lib/task/model.dart#newcode434 pkg/analyzer/lib/task/model.dart:434: final AnalysisTarget target; I suspect this will always ...
4 years, 6 months ago (2016-06-08 22:21:55 UTC) #2
scheglov
4 years, 6 months ago (2016-06-09 15:31:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
979543e3a8356ef7c775a689613278c5ea7e3101 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698