Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2050553003: Moves Blink mixed content enums and helper methods to public. (Closed)

Created:
4 years, 6 months ago by carlosk
Modified:
4 years, 6 months ago
Reviewers:
Mike West
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, caseq+blink_chromium.org, chromium-reviews, clamy, devtools-reviews_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, Nate Chapin, kozyatinskiy+blink_chromium.org, loading-reviews_chromium.org, lushnikov+blink_chromium.org, nasko, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves Blink mixed content enums and helper methods to public. To allow the sharing of data and helper functions related to mixed content between the renderer and the browser. This is in preparation to the moving of the mixed content checks logic to the browser for navigation loads. BUG=576270 Committed: https://crrev.com/982dad78b12be5fbf288da813d6fe755675ca01d Cr-Commit-Position: refs/heads/master@{#399160}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Minor updates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -193 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.h View 4 chunks +2 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 2 8 chunks +22 lines, -155 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 chunks +2 lines, -1 line 0 comments Download
A third_party/WebKit/Source/platform/exported/WebMixedContent.cpp View 1 chunk +169 lines, -0 lines 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/public/platform/WebMixedContent.h View 1 chunk +18 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
carlosk
mkwst@: PTAL. Another preparation step for the mixed content move. Here I'm making public the ...
4 years, 6 months ago (2016-06-08 13:29:05 UTC) #2
Mike West
LGTM
4 years, 6 months ago (2016-06-10 09:43:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050553003/40001
4 years, 6 months ago (2016-06-10 10:03:42 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-10 12:05:39 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 12:05:42 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 12:07:18 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/982dad78b12be5fbf288da813d6fe755675ca01d
Cr-Commit-Position: refs/heads/master@{#399160}

Powered by Google App Engine
This is Rietveld 408576698