Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: components/cronet/ios/BUILD.gn

Issue 2050483002: [Cronet] Coalesce small buffers into single QUIC packet in GRPC on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Helen's comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/BUILD.gn
diff --git a/components/cronet/ios/BUILD.gn b/components/cronet/ios/BUILD.gn
index be173c3bbc5127a03aa69c8ea3a5ca8fd8cfe3d9..19ff7514cf2e3ed18404b4541d512bd9370e9519 100644
--- a/components/cronet/ios/BUILD.gn
+++ b/components/cronet/ios/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import("//build/buildflag_header.gni")
+import("//build/config/ios/rules.gni")
import("//build/util/version.gni")
import("//chrome/version.gni")
import("//testing/test.gni")
@@ -39,8 +40,6 @@ source_set("cronet_sources") {
"../histogram_manager.h",
"../url_request_context_config.cc",
"../url_request_context_config.h",
- "Cronet.h",
- "Cronet.mm",
"cronet_bidirectional_stream.cc",
"cronet_bidirectional_stream.h",
"cronet_c_for_grpc.cc",
@@ -54,13 +53,28 @@ source_set("cronet_sources") {
}
}
-shared_library("cronet_shared") {
+ios_framework_bundle("cronet_framework") {
+ output_name = "Cronet"
+
deps = [
":cronet_sources",
"//base",
"//net:net",
]
+
+ info_plist = "Info.plist"
+
libs = [ "UIKit.Framework" ]
+
+ public_headers = [
+ "Cronet.h",
+ "cronet_c_for_grpc.h",
+ ]
+
+ sources = [
+ "Cronet.h",
+ "Cronet.mm",
+ ]
}
bundle_data("cronet_test_bundle_data") {
@@ -133,7 +147,7 @@ action("generate_license") {
copy("cronet_package_copy") {
sources = [
- "$root_out_dir/libcronet_shared.dylib",
+ "$root_out_dir/Cronet.framework",
"//AUTHORS",
"//chrome/VERSION",
"//components/cronet/ios/Cronet.h",
@@ -144,7 +158,7 @@ copy("cronet_package_copy") {
]
deps = [
- ":cronet_shared",
+ ":cronet_framework",
]
}

Powered by Google App Engine
This is Rietveld 408576698