[Cronet] Coalesce small buffers into single QUIC packet in GRPC on iOS.

components/cronet/ios/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
+import("//build/config/ios/rules.gni")
 import("//build/util/version.gni")
 import("//chrome/version.gni")
 import("//testing/test.gni")
 import("//url/features.gni")
 
 assert(!is_component_build, "Cronet requires static library build.")
 
 declare_args() {
   cronet_enable_data_reduction_proxy_support = false
 }
@@ skipping 16 matching lines @@
     "//components/prefs:prefs",
     "//net",
     "//url",
   ]
 
   sources = [
     "../histogram_manager.cc",
     "../histogram_manager.h",
     "../url_request_context_config.cc",
     "../url_request_context_config.h",
-    "Cronet.h",
-    "Cronet.mm",
     "cronet_bidirectional_stream.cc",
     "cronet_bidirectional_stream.h",
     "cronet_c_for_grpc.cc",
     "cronet_c_for_grpc.h",
     "cronet_environment.cc",
     "cronet_environment.h",
   ]
 
   if (!use_platform_icu_alternatives) {
     deps += [ "//base:i18n" ]
   }
 }
 
-shared_library("cronet_shared") {
+ios_framework_bundle("cronet_framework") {

[kapishnikov, 2016/06/13 21:21:56]

Where do we specify such things like 'xcode_settings' to choose whether debug
symbols should be stripped and dsym files generated?

[mef, 2016/06/14 00:20:37]

That's a good question, I don't know yet.

+  output_name = "Cronet"
+
   deps = [
     ":cronet_sources",
     "//base",
     "//net:net",
   ]
+
+  info_plist = "Info.plist"
+
   libs = [ "UIKit.Framework" ]
+
+  public_headers = [
+    "Cronet.h",
+    "cronet_c_for_grpc.h",
+  ]
+
+  sources = [
+    "Cronet.h",
+    "Cronet.mm",
+  ]
 }
 
 bundle_data("cronet_test_bundle_data") {
   testonly = true
   sources = [
     "//net/data/ssl/certificates/quic_test.example.com.crt",
     "//net/data/ssl/certificates/quic_test.example.com.key",
     "//net/data/ssl/certificates/quic_test.example.com.key.pkcs8",
     "//net/data/ssl/certificates/quic_test.example.com.key.sct",
   ]
@@ skipping 50 matching lines @@
   outputs = [
     _license_path,
   ]
   args = [
     "license",
     rebase_path(_license_path, root_build_dir),
     "--gn",
   ]
 }
 
 copy("cronet_package_copy") {

[kapishnikov, 2016/06/13 21:21:56]

Do we need this target for the dynamic framework? It depends on
"cronet_framework" target. I would expect that it should package the framework
properly. We copy other resources (like VERSION) in package_ios.py.

[mef, 2016/06/14 00:20:37]

Also good question. I think we need to generate license file as part of gn
build, but package copy doesn't have to be a part of it.

   sources = [
-    "$root_out_dir/libcronet_shared.dylib",
+    "$root_out_dir/Cronet.framework",
     "//AUTHORS",
     "//chrome/VERSION",
     "//components/cronet/ios/Cronet.h",
     "//components/cronet/ios/cronet_c_for_grpc.h",
   ]
   outputs = [
     "$_package_dir/{{source_file_part}}",
   ]
 
   deps = [
-    ":cronet_shared",
+    ":cronet_framework",
   ]
 }
 
 group("cronet_package") {
   deps = [
     ":cronet_package_copy",
     ":generate_license",
   ]
 }