Disable tail calls inside Simple GM functions.

Disable tail calls inside Simple GM functions.

I haven't found any way to turn off the particular optimization (-foptimize-sibling-calls)
per-function, but I can control optimization settings coarsely:

   - on GCC, we can pick a particular -O level, so I've picked -O1 which does not
     enable -foptimize-sibling-calls
   - on Clang, we can only disable all optimization for a function
   - have no idea about MSVC

This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
show up on stack traces when we crash.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006

Committed: https://skia.googlesource.com/skia/+/eee3ced68f787aadc47fa274ca8e13b354ec920a

[mtklein_C, 2016-06-09 15:52:30]

Description was changed from

==========
Disable tail calls inside Simple GM functions.

I haven't found any way to turn off the particular optimization
(-foptimize-sibling-calls)
per-function, but I can control optimization settings coarsely:

   - on GCC, we can pick a particular -O level, so I've picked -O1 which does
not
     enable -foptimize-sibling-calls
   - on Clang, we can only disable all optimization for a function
   - have no idea about MSVC

This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
show up on stack traces when we crash.

BUG=skia:
==========

to

==========
Disable tail calls inside Simple GM functions.

I haven't found any way to turn off the particular optimization
(-foptimize-sibling-calls)
per-function, but I can control optimization settings coarsely:

   - on GCC, we can pick a particular -O level, so I've picked -O1 which does
not
     enable -foptimize-sibling-calls
   - on Clang, we can only disable all optimization for a function
   - have no idea about MSVC

This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
show up on stack traces when we crash.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006
==========

[mtklein_C, 2016-06-09 15:53:12]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[mtklein_C, 2016-06-09 15:53:12]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-06-09 15:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050473006/1

[commit-bot: I haz the power, 2016-06-09 15:53:25]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-06-09 21:53 UTC

[reed1, 2016-06-09 17:28:03]

lgtm

[commit-bot: I haz the power, 2016-06-09 17:30:07]

Description was changed from

==========
Disable tail calls inside Simple GM functions.

I haven't found any way to turn off the particular optimization
(-foptimize-sibling-calls)
per-function, but I can control optimization settings coarsely:

   - on GCC, we can pick a particular -O level, so I've picked -O1 which does
not
     enable -foptimize-sibling-calls
   - on Clang, we can only disable all optimization for a function
   - have no idea about MSVC

This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
show up on stack traces when we crash.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006
==========

to

==========
Disable tail calls inside Simple GM functions.

I haven't found any way to turn off the particular optimization
(-foptimize-sibling-calls)
per-function, but I can control optimization settings coarsely:

   - on GCC, we can pick a particular -O level, so I've picked -O1 which does
not
     enable -foptimize-sibling-calls
   - on Clang, we can only disable all optimization for a function
   - have no idea about MSVC

This should make sure the simple GM functions, e.g. all_bitmap_configs_GM(),
show up on stack traces when we crash.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050473006

Committed:
https://skia.googlesource.com/skia/+/eee3ced68f787aadc47fa274ca8e13b354ec920a
==========

[commit-bot: I haz the power, 2016-06-09 17:30:08]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eee3ced68f787aadc47fa274ca8e13b354ec920a

[mtklein, 2016-06-09 18:59:32]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2051193002/ by mtklein@google.com.

The reason for reverting is: Appears to have broken
Test-Ubuntu-GCC-GCE-CPU-AVX2-x86-Debug.