third_party/WebKit/Source/core/dom/ElementRareData.cpp - Issue 2050463003: Check if Member owner thread matches pointer thread and current thread

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementRareData.cpp

Issue 2050463003: Check if Member owner thread matches pointer thread and current thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2012 Google Inc. All rights reserved.	2 * Copyright (C) 2012 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 }	101 }

102 }	102 }

103 visitor->traceWrappers(m_shadow);	103 visitor->traceWrappers(m_shadow);

104 visitor->traceWrappers(m_attributeMap);	104 visitor->traceWrappers(m_attributeMap);

105 visitor->traceWrappers(m_dataset);	105 visitor->traceWrappers(m_dataset);

106 visitor->traceWrappers(m_classList);	106 visitor->traceWrappers(m_classList);

107 visitor->traceWrappers(m_intersectionObserverData);	107 visitor->traceWrappers(m_intersectionObserverData);

108 NodeRareData::traceWrappersAfterDispatch(visitor);	108 NodeRareData::traceWrappersAfterDispatch(visitor);

109 }	109 }

110	110

	111 #if !DCHECK_IS_ON()
	haraken 2016/08/16 13:27:13 Can we update SameSizeAsElementRareData so that we Can we update SameSizeAsElementRareData so that we don't need to disable the static assert in DCHECK_IS_ON? keishi 2016/08/17 11:18:28 Done. Also renamed SameSizeAsElementRareData::pers Show quoted text On 2016/08/16 13:27:13, haraken wrote: > > Can we update SameSizeAsElementRareData so that we don't need to disable the > static assert in DCHECK_IS_ON? Done. Also renamed SameSizeAsElementRareData::persistentMember to SameSizeAsElementRareData::members because we no longer use PersistentWillBeMember.
111 static_assert(sizeof(ElementRareData) == sizeof(SameSizeAsElementRareData), "Ele mentRareData should stay small");	112 static_assert(sizeof(ElementRareData) == sizeof(SameSizeAsElementRareData), "Ele mentRareData should stay small");

	113 #endif

112	114

113 } // namespace blink	115 } // namespace blink

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('J')