Issue 20504002: Fix bug where updates to registration status don't show up

Issue 20504002: Fix bug where updates to registration status don't show up (Closed)

Created:
7 years, 4 months ago by Noam Samuel

Modified:
7 years, 4 months ago

Reviewers:
gene

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix bug where updates to registration status don't show up Fix bug in devices page where a printer's registration status is not updated in the table when it is registered, and refactor onServiceUpdate to make it more readable. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218064

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Update to match changes in parent CL #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -40 lines)			Patch
	M	chrome/browser/resources/local_discovery/local_discovery.js	View	1 2 3 4 5	3 chunks	+58 lines, -40 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Noam Samuel

On 2013/07/26 16:00:37, gene wrote: > lgtm Updated to add localization

7 years, 4 months ago (2013-08-02 23:00:12 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/20504002/18001

7 years, 4 months ago (2013-08-15 22:30:42 UTC) #5

commit-bot: I haz the power

Retried try job too often on mac_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=160588

7 years, 4 months ago (2013-08-16 01:57:06 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/20504002/18001

7 years, 4 months ago (2013-08-16 17:47:46 UTC) #7

Message was sent while issue was closed.

Change committed as 218064

Expand Messages | Collapse Messages