Chromium Code Reviews
DescriptionI'm expanding this to fix a couple of bugs in determining the file name for
dragging images:
. It's possible for the extension to be empty, resulting in a bad file
name, for example, 'foo.' or just '.'.
. We weren't restricting the size of the file to MAX_PATH.
. We weren't removing characters that are invalid for file system names.
It's possible to put this code up in OSExchangeData rather than
here, but it feels best to centralize it here so that we don't have to
worry about bad file names leaking into other code.
I tried hard to write a layout test for this, but it seems we don't
really use the file name in test shell so that I couldn't get
coverage.
BUG=7023
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10206
Patch Set 1 #Patch Set 2 : '' #
Total comments: 1
Patch Set 3 : '' #
Messages
Total messages: 3 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||