Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2050373002: Revert of Add control of manual mipmapping to GrContextOptions (Closed)

Created:
4 years, 6 months ago by mtklein_C
Modified:
4 years, 6 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add control of manual mipmapping to GrContextOptions (patchset #2 id:20001 of https://codereview.chromium.org/2054623003/ ) Reason for revert: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-Golo-GPU-GT610-x86_64-Debug-ASAN/builds/3481/steps/test_skia%20on%20Ubuntu/logs/stdio ../../../src/gpu/gl/GrGLCaps.cpp:554:25: runtime error: load of value 187, which is not a valid value for type 'bool' SUMMARY: AddressSanitizer: undefined-behavior ../../../src/gpu/gl/GrGLCaps.cpp:554:25 in step returned non-zero exit code: 1 Original issue's description: > Add control of manual mipmapping to GrContextOptions > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2054623003 > > Committed: https://skia.googlesource.com/skia/+/97e398d98928f9497063594ebe633efe2d0f4968 TBR=bsalomon@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/e239547269c7e6677a7ed6ecdf67234fda662427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M include/gpu/GrContextOptions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein_C
Created Revert of Add control of manual mipmapping to GrContextOptions
4 years, 6 months ago (2016-06-09 19:19:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050373002/1
4 years, 6 months ago (2016-06-09 19:20:04 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 19:20:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e239547269c7e6677a7ed6ecdf67234fda662427

Powered by Google App Engine
This is Rietveld 408576698