src/factory.cc - Issue 2050343002: [regexp] Experimental support for regexp named captures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2050343002: [regexp] Experimental support for regexp named captures (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 0ad99a61e41dffc7279be56b0fe2371bff40b19c..0ad784a5e47319272898e629dda6bf9d493d2afb 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -2391,6 +2391,7 @@ void Factory::SetRegExpIrregexpData(Handle<JSRegExp> regexp,

store->set(JSRegExp::kIrregexpMaxRegisterCountIndex, Smi::FromInt(0));

store->set(JSRegExp::kIrregexpCaptureCountIndex,

Smi::FromInt(capture_count));

+ store->set(JSRegExp::kIrregexpCaptureNameMapIndex, uninitialized);

regexp->set_data(*store);

}

« no previous file with comments | « src/bootstrapper.cc ('k') | src/flag-definitions.h » ('j') | no next file with comments »