Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 205033007: Revert of Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. (Closed)

Created:
6 years, 9 months ago by wibling-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, rune+blink, caseq+blink_chromium.org, arv+blink, yurys+blink_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, rwlbuis, kenneth.christiansen, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Revert of Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. (https://codereview.chromium.org/195953003/) Reason for revert: Breaking tests. Original issue's description: > Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG=341815 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169652 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org NOTREECHECKS=true NOTRY=true BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -141 lines) Patch
M Source/core/css/CSSComputedStyleDeclaration.h View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSFilterRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFilterRule.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSFontFaceRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSFontFaceRule.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSKeyframeRule.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/CSSPageRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPageRule.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.h View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/css/CSSStyleDeclaration.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/CSSStyleRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleRule.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/css/CSSViewportRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSViewportRule.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.h View 4 chunks +6 lines, -22 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 8 chunks +3 lines, -43 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/EditingStyle.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/Internals.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
wibling-chromium
Created Revert of Oilpan: Move CSSStyleDeclaration and subclasses to the heap using transistion types.
6 years, 9 months ago (2014-03-20 15:52:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/205033007/1
6 years, 9 months ago (2014-03-20 15:53:16 UTC) #2
commit-bot: I haz the power
Change committed as 169661
6 years, 9 months ago (2014-03-20 15:53:52 UTC) #3
Mads Ager (chromium)
LGTM, thanks!
6 years, 9 months ago (2014-03-20 15:57:31 UTC) #4
haraken
6 years, 9 months ago (2014-03-20 16:38:44 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698