Source/core/page/FocusController.cpp - Issue 205033004: Dispatch change and blur event for input type=text when window focus is changed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/FocusController.cpp

Issue 205033004: Dispatch change and blur event for input type=text when window focus is changed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using setFocus instead of dispatchChange mechanism Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/forms/text/text-window-lost-focus-change-event.html ('K') | « LayoutTests/fast/forms/text/text-window-lost-focus-change-event-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/page/FocusController.cpp

diff --git a/Source/core/page/FocusController.cpp b/Source/core/page/FocusController.cpp

index 8c0002e58fee5754ad3ce1e2135aa09b61563354..c32f34c7db59a876abcd4763dd3473ef4042d1c1 100644

--- a/Source/core/page/FocusController.cpp

+++ b/Source/core/page/FocusController.cpp

@@ -144,7 +144,11 @@ static inline void dispatchEventsOnWindowAndFocusedNode(Document* document, bool

if (!focused && document->focusedElement()) {

RefPtr<Element> focusedElement(document->focusedElement());

- focusedElement->dispatchBlurEvent(0);

+ if (focusedElement && focusedElement->isHTMLElement()) {

+ toHTMLElement(focusedElement)->setFocus(false);

tkent 2014/03/31 07:35:37 We don't need to check isHTMLElement, and don't ne

Habib Virji 2014/03/31 09:30:15 Done.

+ }

+ if (focusedElement == document->focusedElement())

tkent 2014/03/31 07:35:37 We don't need to check it. setFocus(false) don't

Habib Virji 2014/03/31 09:30:15 Done.

+ focusedElement->dispatchBlurEvent(0);

if (focusedElement == document->focusedElement()) {

focusedElement->dispatchFocusOutEvent(EventTypeNames::focusout, 0);

if (focusedElement == document->focusedElement())