Convert track-webvtt-tc[022, 023] tests to testharness.js

Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/49f00060d54983386dcb418da499083d40e37cfa
Cr-Commit-Position: refs/heads/master@{#399118}

[Srirama, 2016-06-09 13:00:54]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[Srirama, 2016-06-09 14:36:35]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-06-09 14:53:40]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-09 14:53:41]

PTAL

[fs, 2016-06-09 15:08:30]

https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html
(right):

https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html:10:
var fragmentText = "The following bear is bold:\n";
Looks like this could go as the first "child" (entry) in |children|? (Same for
all of these.)

https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html:112:
for (var node of nodeStruct) {
Looks like this could recurse on the inner list here. Then maybe a shape like:

function createFragment(children) {
  var fragment = document.createDocumentFragment();
  cloneChildrenToFragment(fragment, children);
  return fragment;
}

function cloneChildrenToFragment(root, children) {
  for (var child in children) {
    if (child.type == "text")
      var child = document.createTextNode(child.value);
    else {
      var child = document.createElement(child.type);
      cloneChildrenToFragmen(child, child.value);
    }
    root.appendChild(child);
  }
}

[fs, 2016-06-09 15:09:49]

On 2016/06/09 at 15:08:30, fs wrote:
>
https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html
(right):
> 
>
https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html:10:
var fragmentText = "The following bear is bold:\n";
> Looks like this could go as the first "child" (entry) in |children|? (Same for
all of these.)
> 
>
https://codereview.chromium.org/2050213003/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html:112:
for (var node of nodeStruct) {
> Looks like this could recurse on the inner list here. Then maybe a shape like:
> 
> function createFragment(children) {
>   var fragment = document.createDocumentFragment();
>   cloneChildrenToFragment(fragment, children);
>   return fragment;
> }
> 
> function cloneChildrenToFragment(root, children) {
>   for (var child in children) {
>     if (child.type == "text")
>       var child = document.createTextNode(child.value);

Uhm, maybe "childElement" or so for this one (and the next)... but I you catch
the drift I think.

>     else {
>       var child = document.createElement(child.type);
>       cloneChildrenToFragmen(child, child.value);
>     }
>     root.appendChild(child);
>   }
> }

[Srirama, 2016-06-09 18:24:02]

Patchset #1 (id:20001) has been deleted

[Srirama, 2016-06-09 18:27:08]

Sorry deleted patchset1 by mistake :(
I have addressed comments, PTAL.

[fs, 2016-06-09 18:44:45]

lgtm

[Srirama, 2016-06-10 04:58:05]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-06-10 04:58:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2050213003/50001

[commit-bot: I haz the power, 2016-06-10 06:22:26]

Description was changed from

==========
Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

[commit-bot: I haz the power, 2016-06-10 06:22:27]

Committed patchset #2 (id:50001)

[commit-bot: I haz the power, 2016-06-10 06:22:29]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 06:23:42]

Description was changed from

==========
Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests. 

BUG=588956
==========

to

==========
Convert track-webvtt-tc[022, 023] tests to testharness.js

Cleaning up track-webvtt-tc[022, 023] tests in media/track
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/49f00060d54983386dcb418da499083d40e37cfa
Cr-Commit-Position: refs/heads/master@{#399118}
==========

[commit-bot: I haz the power, 2016-06-10 06:23:43]

Patchset 2 (id:??) landed as
https://crrev.com/49f00060d54983386dcb418da499083d40e37cfa
Cr-Commit-Position: refs/heads/master@{#399118}