Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2050143002: headless: Use HeadlessAsyncDevTooledBrowserTest in HeadlessDevToolsClient tests. (Closed)

Created:
4 years, 6 months ago by Eric Seckler
Modified:
4 years, 6 months ago
Reviewers:
Sami
CC:
chromium-reviews, altimin, alex clarke (OOO till 29th)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use HeadlessAsyncDevTooledBrowserTest in HeadlessDevToolsClient tests. BUG=546953 Committed: https://crrev.com/f9ca57e1686dc307883b6d68aafdb105d3c44c95 Cr-Commit-Position: refs/heads/master@{#398835}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -61 lines) Patch
M headless/lib/headless_devtools_client_browsertest.cc View 6 chunks +21 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Eric Seckler
Just a quick refactor to remove some duplication... :)
4 years, 6 months ago (2016-06-09 09:41:21 UTC) #3
Sami
lgtm, thanks for the cleanup.
4 years, 6 months ago (2016-06-09 09:56:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050143002/1
4 years, 6 months ago (2016-06-09 09:58:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 10:45:06 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 10:46:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9ca57e1686dc307883b6d68aafdb105d3c44c95
Cr-Commit-Position: refs/heads/master@{#398835}

Powered by Google App Engine
This is Rietveld 408576698