Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 205013002: The blink half of the new ServiceWorker 'sync' event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 205013002: The blink half of the new ServiceWorker 'sync' event. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | public/web/WebServiceWorkerContextProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 10b5cff59cf7575a133eb5fb2d86729c59e4e250..b4b71c2a5ab0b2276645e2557e65a1c9fae12eb9 100644

--- a/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -68,6 +68,12 @@ void ServiceWorkerGlobalScopeClientImpl::didHandleFetchEvent(int fetchEventID, P

m_client->didHandleFetchEvent(fetchEventID, webResponse);

}

+void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID)

+ if (m_client)

michaeln 2014/03/20 23:07:28 Not related to your CL, but i don't see how/why m_

jkarlin 2014/03/21 16:50:55 Agreed. Removed the conditionals.

+ m_client->didHandleSyncEvent(syncEventID);

ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(PassOwnPtr<WebServiceWorkerContextClient> client)

: m_client(client)

{

« no previous file with comments | « Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | public/web/WebServiceWorkerContextProxy.h » ('J')