Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 205013002: The blink half of the new ServiceWorker 'sync' event. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 if (!response) { 61 if (!response) {
62 m_client->didHandleFetchEvent(fetchEventID); 62 m_client->didHandleFetchEvent(fetchEventID);
63 return; 63 return;
64 } 64 }
65 65
66 WebServiceWorkerResponse webResponse; 66 WebServiceWorkerResponse webResponse;
67 response->populateWebServiceWorkerResponse(webResponse); 67 response->populateWebServiceWorkerResponse(webResponse);
68 m_client->didHandleFetchEvent(fetchEventID, webResponse); 68 m_client->didHandleFetchEvent(fetchEventID, webResponse);
69 } 69 }
70 70
71 void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID)
72 {
73 if (m_client)
michaeln 2014/03/20 23:07:28 Not related to your CL, but i don't see how/why m_
jkarlin 2014/03/21 16:50:55 Agreed. Removed the conditionals.
74 m_client->didHandleSyncEvent(syncEventID);
75 }
76
71 ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(PassOwnPt r<WebServiceWorkerContextClient> client) 77 ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(PassOwnPt r<WebServiceWorkerContextClient> client)
72 : m_client(client) 78 : m_client(client)
73 { 79 {
74 } 80 }
75 81
76 } // namespace blink 82 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698