third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h ('K') | « third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h ('k') | third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h

diff --git a/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h b/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h

index 616b82320a6b507ae5c5f32f743bef39b97a98ae..7d824bdbd77c471c8b374cca91eaa16615f7ada6 100644

--- a/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h

+++ b/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h

@@ -8,7 +8,7 @@

#include "modules/ModulesExport.h"

#include "platform/Supplementable.h"

#include "public/platform/WebSetSinkIdCallbacks.h"

-#include "wtf/PassOwnPtr.h"

+#include <memory>

namespace blink {

@@ -22,7 +22,7 @@ public:

virtual ~AudioOutputDeviceClient() {}

// Checks that a given sink exists and has permissions to be used from the origin of the current frame.

- virtual void checkIfAudioSinkExistsAndIsAuthorized(ExecutionContext*, const WebString& sinkId, PassOwnPtr<WebSetSinkIdCallbacks>) = 0;

+ virtual void checkIfAudioSinkExistsAndIsAuthorized(ExecutionContext*, const WebString& sinkId, std::unique_ptr<WebSetSinkIdCallbacks>) = 0;

// Supplement requirements.

static AudioOutputDeviceClient* from(ExecutionContext*);