third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h ('K') | « third_party/WebKit/Source/modules/compositorworker/CompositorWorkerMessagingProxy.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h

diff --git a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h

index 9e349071198bea14273638c2058f1e6acfd0e0b5..c8b7d7552bc70bb3937efc248a77714efd344562 100644

--- a/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h

+++ b/third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThread.h

@@ -7,6 +7,7 @@

#include "core/workers/WorkerThread.h"

#include "modules/ModulesExport.h"

+#include <memory>

namespace blink {

@@ -15,7 +16,7 @@ class InProcessWorkerObjectProxy;

// This class is overridden in unit-tests.

class MODULES_EXPORT CompositorWorkerThread final : public WorkerThread {

public:

- static PassOwnPtr<CompositorWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

+ static std::unique_ptr<CompositorWorkerThread> create(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

~CompositorWorkerThread() override;

InProcessWorkerObjectProxy& workerObjectProxy() const { return m_workerObjectProxy; }

@@ -33,7 +34,7 @@ public:

protected:

CompositorWorkerThread(PassRefPtr<WorkerLoaderProxy>, InProcessWorkerObjectProxy&, double timeOrigin);

- WorkerGlobalScope* createWorkerGlobalScope(PassOwnPtr<WorkerThreadStartupData>) override;

+ WorkerGlobalScope* createWorkerGlobalScope(std::unique_ptr<WorkerThreadStartupData>) override;

private:

InProcessWorkerObjectProxy& m_workerObjectProxy;