third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

diff --git a/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp b/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

index 5f441468b57f2181108e173ec1d325aba0f93783..d10c1afc6100539a88c8208178590c07717fea43 100644

--- a/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

+++ b/third_party/WebKit/Source/core/dom/SelectorQueryTest.cpp

@@ -8,6 +8,7 @@

#include "core/dom/Document.h"

#include "core/html/HTMLHtmlElement.h"

#include "testing/gtest/include/gtest/gtest.h"

+#include <memory>

namespace blink {

@@ -19,7 +20,7 @@ TEST(SelectorQueryTest, NotMatchingPseudoElement)

document->documentElement()->setInnerHTML("<body><style>span::before { content: 'X' }</style><span></span></body>", ASSERT_NO_EXCEPTION);

CSSSelectorList selectorList = CSSParser::parseSelector(CSSParserContext(*document, nullptr), nullptr, "span::before");

- OwnPtr<SelectorQuery> query = SelectorQuery::adopt(std::move(selectorList));

+ std::unique_ptr<SelectorQuery> query = SelectorQuery::adopt(std::move(selectorList));

Element* elm = query->queryFirst(*document);

EXPECT_EQ(nullptr, elm);