third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h ('K') | « third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h ('k') | third_party/WebKit/Source/modules/app_banner/AppBannerPromptResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

index f0ad546b16baff84352042f3d090676c59dfa8dc..78b6bf0f024e2d1840ca5e70bf61baffaaec355c 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp

@@ -15,6 +15,7 @@

#include "modules/accessibility/AXObjectCacheImpl.h"

#include "modules/accessibility/InspectorTypeBuilderHelper.h"

#include "platform/inspector_protocol/Values.h"

+#include <memory>

namespace blink {

@@ -381,7 +382,7 @@ void InspectorAccessibilityAgent::getAXNode(ErrorString* errorString, int nodeId

return;

Document& document = node->document();

- OwnPtr<ScopedAXObjectCache> cache = ScopedAXObjectCache::create(document);

+ std::unique_ptr<ScopedAXObjectCache> cache = ScopedAXObjectCache::create(document);

AXObjectCacheImpl* cacheImpl = toAXObjectCacheImpl(cache->get());

AXObject* axObject = cacheImpl->getOrCreate(node);

if (!axObject || axObject->accessibilityIsIgnored()) {