third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequestUpload.h ('K') | « third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp ('k') | third_party/WebKit/Source/modules/background_sync/SyncError.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

index 9b6e3e7cb993da72fe7a40c85c109755dcd9c5ed..b25dae9460c5ab179ab996870cb8db7ce70e986c 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

@@ -7,8 +7,8 @@

#include "bindings/core/v8/ScriptPromiseResolver.h"

#include "modules/background_sync/SyncError.h"

#include "modules/serviceworkers/ServiceWorkerRegistration.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

+#include "wtf/PtrUtil.h"

+#include <memory>

namespace blink {

@@ -30,7 +30,7 @@ void SyncRegistrationCallbacks::onSuccess(std::unique_ptr<WebSyncRegistration> w

return;

}

- OwnPtr<WebSyncRegistration> registration = adoptPtr(webSyncRegistration.release());

+ std::unique_ptr<WebSyncRegistration> registration = wrapUnique(webSyncRegistration.release());

if (!registration) {

m_resolver->resolve(v8::Null(m_resolver->getScriptState()->isolate()));

return;