third_party/WebKit/Source/wtf/text/TextCodecICU.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecICU.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Kent; merge. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/TextCodecICU.h

diff --git a/third_party/WebKit/Source/wtf/text/TextCodecICU.h b/third_party/WebKit/Source/wtf/text/TextCodecICU.h

index 9b11005626912daaf218a48b06c217ec49560741..9b34d647c12eaeaa55a42ec1fcdfd05767adcecb 100644

--- a/third_party/WebKit/Source/wtf/text/TextCodecICU.h

+++ b/third_party/WebKit/Source/wtf/text/TextCodecICU.h

@@ -29,6 +29,7 @@

#include "wtf/text/TextCodec.h"

#include "wtf/text/TextEncoding.h"

+#include <memory>

#include <unicode/utypes.h>

typedef struct UConverter UConverter;

@@ -46,7 +47,7 @@ public:

private:

TextCodecICU(const TextEncoding&);

- static PassOwnPtr<TextCodec> create(const TextEncoding&, const void*);

+ static std::unique_ptr<TextCodec> create(const TextEncoding&, const void*);

String decode(const char*, size_t length, FlushBehavior, bool stopOnError, bool& sawError) override;

CString encode(const UChar*, size_t length, UnencodableHandling) override;